Skip to content

bpo-34363: Handle namedtuples fields correctly in asdict() and astuple(). #8728

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 3 commits into from
Closed

bpo-34363: Handle namedtuples fields correctly in asdict() and astuple(). #8728

wants to merge 3 commits into from

Conversation

ericvsmith
Copy link
Member

@ericvsmith ericvsmith commented Aug 10, 2018 •
edited by bedevere-bot
Loading

suutari
suutari reviewed Aug 10, 2018
View reviewed changes
Lib/test/test_dataclasses.py Outdated
# Make sure we copied these objects and aren't using the
# originals.
self.assertIsNot(d['nt1'], inst1)
self.assertIsNot(d['nt2'], inst1)
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Typo? Should inst1 be inst2 here?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed, thanks.

@ericvsmith
Copy link
Member Author

Closed in preference to #9151.

@ericvsmith ericvsmith closed this Sep 11, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suutari suutari suutari left review comments

Assignees
No one assigned
Labels
awaiting merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ericvsmith @suutari @the-knights-who-say-ni